Re: [Emms-patches] Last.fm Audioscrobbler

[Yoni Rabkin]

Bram van der Kroef <address@hidden> writes:

> It works fine. There are two things I came across in my own code:
> The handshake needs to be done at some point when playing local
> files. Otherwise -assert-submission-handshake gives an error and nothing
> happens. It only needs to be done once per session.
>
> Also, 
> (add-hook 'emms-player-started-hook
>           'emms-lastfm-scrobbler-start-hook)
>
> needs to be changed to
> (add-hook 'emms-player-started-hook
>           'emms-lastfm-scrobbler-start-hook t)
>
> to append it to the end. The -start-hook waits 5 seconds and it delays
> the other hooks.

Go ahead and make all the changes you want and send in the revised
patch. I'll test it for a few days and then push it to the Savannah
repo. Please note that I don't scrobble local tracks at all so I won't
be testing your code paths.

If you can add a patch to the Last.fm section of the manual explaining
how to use your features that would be very much appreciated. Emms is
one of those free software project which maintains useful and relevant
documentation (a hallowed subcategory, I know).

If you want to do further work I would recommend getting commit
access. No need to go through me.

Thanks!

-- 
   "Cut your own wood and it will warm you twice"