[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emms-patches] fix-ampersands-and-question-marks-in-lastfm.dpatch
From: |
Tassilo Horn |
Subject: |
[Emms-patches] fix-ampersands-and-question-marks-in-lastfm.dpatch |
Date: |
Sat, 13 Jan 2007 11:56:18 +0100 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.92 (gnu/linux) |
Hi all,
,----
| Tassilo Horn <address@hidden>**20070113104902
|
| Roman Lagunov reported a bug: the last.fm plugin failed scrobbling
| tracks with & in artist/title/album. The same applies to streams
| containing an ampersand.
|
| So I added ?& and ?? to `emms-url-specials'. But because both are
| needed to submit values via HTTP GET now you have to
| `emms-escape-url' only the arguments that may contain special chars
| instead the complete url, e.g.:
|
| (url-retrieve
| (concat emms-lastfm-server
| "?hs=true&p=1.1"
| "&c=" emms-lastfm-client-id
| "&v=" (number-to-string emms-lastfm-client-version)
| "&u=" (emms-escape-url emms-lastfm-username))
|
| instead of
|
| (url-retrieve
| (emms-escape-url
| (concat emms-lastfm-server
| "?hs=true&p=1.1"
| "&c=" emms-lastfm-client-id
| "&v=" (number-to-string emms-lastfm-client-version)
| "&u=" emms-lastfm-username))
`----
fix-ampersands-and-question-marks-in-lastfm.dpatch
Description: A darcs patch for your repository
Bye,
Tassilo
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Emms-patches] fix-ampersands-and-question-marks-in-lastfm.dpatch,
Tassilo Horn <=