Re: [Emms-patches] Fix regression in emms-lastfm.el

[William Xu]

Tassilo Horn <address@hidden> writes:

> Hi all,

Hi Tassilo, 

> ,----
> | Sat Dec 16 14:22:09 CET 2006  Tassilo Horn <address@hidden>
> |   * fix-regression-in-lastfm.dpatch
> |
> |   My last path enabled emms-lastfm.el to submit tracks even if you
> |   paused them. I tested this extensively! But I didn't test if it
> |   still submits them if you don't pause it. Of course it didn't. ;-)
> |
> |   The problem was that I rely on `emms-playing-time' to calculate when
> |   a track has to be submitted. But in `emms-player-started-hook' my
> |   new track function was run *before* `emms-playing-time' was set to 0
> |   again.
> `----
>
> BTW: I think that `emms-playing-time' should always be enabled and only
> the displaying in the mode-line should be deactivatable via
> `emms-playing-time'. What do you think?

I think you could check and warn if `emms-playing-time' isn't enabled.
And, besides current `emms-playing-time-toggle', i can add a new
`emms-playing-time-toggle-display' toggling displaying on mode-line
while running `emms-playing-time' internally. How does this sound?

> BTW2: Do you use some non-default indentation style? When having a look
> at some other emms files I wonder how they were formatted. My emacs 22
> with the normal emacs-lisp-mode indents differently...

Seems normal here, with default indentation style, of course. Maybe you
could point out `some other emms files'.

-- 
William

According to the Rand McNally Places-Rated Almanac, the best place to live in
America is the city of Pittsburgh.  The city of New York came in twenty-fifth.
Here in New York we really don't care too much.  Because we know that we could
beat up their city anytime.
                -- David Letterman