emms-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emms-patches] darcs patch: allow nonzero ogginfo exit plus some reinden


From: Martin Schoenmakers
Subject: [Emms-patches] darcs patch: allow nonzero ogginfo exit plus some reindenting
Date: Tue, 30 May 2006 15:17:29 +0200

Tue May 30 15:04:11 CEST 2006  Martin Schoenmakers <address@hidden>
  * allow nonzero ogginfo exit plus some reindenting
  
  When ogginfo gave a nonzero value on exit, any valid data would get tossed
  if there was any. This prevented emms from showing info for files that are
  tagged but a bit odd.
  
  Also reindented emms-info-ogginfo accordingly, which incidentally removed
  some tabs in favour of spaces.
  
New patches:

[allow nonzero ogginfo exit plus some reindenting
Martin Schoenmakers <address@hidden>**20060530130411
 
 When ogginfo gave a nonzero value on exit, any valid data would get tossed
 if there was any. This prevented emms from showing info for files that are
 tagged but a bit odd.
 
 Also reindented emms-info-ogginfo accordingly, which incidentally removed
 some tabs in favour of spaces.
 
] {
hunk ./emms-info-ogginfo.el 52
-      (when (zerop
-            (call-process emms-info-ogginfo-program-name
-                          nil t nil (emms-track-name track)))
+      (call-process emms-info-ogginfo-program-name
+                    nil t nil (emms-track-name track))
hunk ./emms-info-ogginfo.el 55
-       ;; play time, emms-info-ogg.el [U. Jensen]
-       (goto-char (point-min))
-       (re-search-forward "Playback length: \\([0-9]*\\)m:\\([0-9]*\\)")
-       (let* ((minutes (string-to-number (match-string 1)))
-              (seconds (string-to-number (match-string 2)))
-              (ptime-total (+ (* minutes 60) seconds))
-              (ptime-min minutes)
-              (ptime-sec seconds))
-         (emms-track-set track 'info-playing-time ptime-total)
-         (emms-track-set track 'info-playing-time-min ptime-min)
-         (emms-track-set track 'info-playing-time-sec ptime-sec)
-         (emms-track-set track 'info-file (emms-track-name track)))
+      ;; play time, emms-info-ogg.el [U. Jensen]
+      (goto-char (point-min))
+      (re-search-forward "Playback length: \\([0-9]*\\)m:\\([0-9]*\\)")
+      (let* ((minutes (string-to-number (match-string 1)))
+             (seconds (string-to-number (match-string 2)))
+             (ptime-total (+ (* minutes 60) seconds))
+             (ptime-min minutes)
+             (ptime-sec seconds))
+        (emms-track-set track 'info-playing-time ptime-total)
+        (emms-track-set track 'info-playing-time-min ptime-min)
+        (emms-track-set track 'info-playing-time-sec ptime-sec)
+        (emms-track-set track 'info-file (emms-track-name track)))
hunk ./emms-info-ogginfo.el 68
-       ;; all the rest of the info available
-       (goto-char (point-min))
-       (when (re-search-forward "^.*\\.\\.\\.$" (point-max) t)
-         (while (zerop (forward-line 1))
-           (when (looking-at "^\t\\(.*\\)=\\(.*\\)$")
-             (let ((a (match-string 1))
-                   (b (match-string 2)))
-               (when (and (< 0 (length a))
-                          (< 0 (length b)))
-                 (emms-track-set track
-                                 (intern (downcase (concat "info-" 
(match-string 1))))
-                                 (match-string 2)))))))))))
+      ;; all the rest of the info available
+      (goto-char (point-min))
+      (when (re-search-forward "^.*\\.\\.\\.$" (point-max) t)
+        (while (zerop (forward-line 1))
+          (when (looking-at "^\t\\(.*\\)=\\(.*\\)$")
+            (let ((a (match-string 1))
+                  (b (match-string 2)))
+              (when (and (< 0 (length a))
+                         (< 0 (length b)))
+                (emms-track-set track
+                                (intern (downcase (concat "info-" 
(match-string 1))))
+                                (match-string 2))))))))))
}

Context:

[emms-streams: Implement kill and yank.
Michael Olson <address@hidden>**20060530040114] 
[emms-streams: Make hitting RET on a URL do the right thing, improve cursor 
movement, and mark the buffer as unmodified after performing a save.
Michael Olson <address@hidden>**20060529030043] 
[emms-player-mpd: Make seek work correctly.
Michael Olson <address@hidden>**20060525033120] 
[emms-player-mpd: Use more robust method of detecting whether we need to 
force-feed MusicPD our playlist.
Michael Olson <address@hidden>**20060525014253] 
[emms-playlist-mode: Make "d" kill the entire line.  This seems to be a good 
compromise of those who use C-k and those who want more standard object-killing 
behavior.
foo**20060524200008] 
[emms-player-mpd: When showing the currently-playing song, prepend the name of 
the radio station, if it exists.
foo**20060524195911] 
[emms-player-mpd: Fix bug that caused unconditional reloading of the entire 
MusicPD playlist whenever the track was changed manually.
Michael Olson <address@hidden>**20060524061655] 
[emms-player-mpd: Overhaul for streamlist support, and fix a few miscellaneous 
issues.
Michael Olson <address@hidden>**20060524055707] 
[emms-player-mpd: Add a few checks to make sure that the given buffer exists 
before trying to do anything with it.
Michael Olson <address@hidden>**20060517035419] 
[emms-source-playlist: Do not expand names of files in playlists, as this can 
cause problems with emms-player-mpd in some configurations.
Michael Olson <address@hidden>**20060516081257] 
[emms-playlist-mode: Implement the option (disabled by default) of opening a 
new EMMS buffer for a playlist, when hitting RET on one.
Michael Olson <address@hidden>**20060510040730] 
[emms-playlist-mode.el: Don't put a period after the mode map. This hangs 21.4 
on display.
address@hidden 
[TAG 2.0
address@hidden 
Patch bundle hash:
ca220b6298cd44fd3247bef5d10f762241a589aa

reply via email to

[Prev in Thread] Current Thread [Next in Thread]