Re: [Solved] Re: mpv flags slightly broken

[Mike Kazantsev]

On Thu, 11 Jan 2024 18:57:31 -1000
Bob Newell <bobnewell@bobnewell.net> wrote:

> In the previous mpv version this came back as 'ipc-socket and everything
> was fine.  In the current mpv version it came back as 'file which wasn't
> fine at all and couldn't work as in emms startup I set command line optons
> for 'ipc-socket.
> 
> However merely changing 'nil' to 'ipc-socket' (for
> emms-plaer-mpv-ipc-method) didn't work either and resulted in mpv never
> even starting (from emms).
> 
> So I had to create ~/.config/emms/mpv.conf and add the line
> 
> input-ipc-server=/home/bnewell/.emacs.d/emms/mpv-ipc.sock
...
> 
> So no, this is not an emms problem per se.  No bug but mpv now works
> differently so I had to slightly change my emms setup.

No no, I think it's totally a bug in emms-player-mpv.el, as it should:

 A. Detect supported IPC method as unix socket correctly. It did not.

 B. Do not require input-ipc-server mpv option, as it should pass it in
    emms-player-mpv-proc-init on the command line.

 C. Work with fifo mode too, or not even have that option.

I think [A] fails because mpv changed --version output, now there's an
extra "v" in there, which regexp for version number doesn't catch.

If I did restart my emacs after "pacman -Syu", I'd have probably
reproduced this issue, but since I didn't earlier, it still had the
right IPC method set in that var, despite using same mpv version.

Not sure why [B] doesn't work, maybe emms-directory doesn't exist,
so socket there couldn't be created? 

Will need to check where it might be auto-created or not, though can be
something else entirely, this just seem to be simplest explaination
that also covers [C], as I think that fifo path should passed with same
dir to mpv.

So normally you shouldn't need to change any options, and it "just
works", but this probably surfaced at least two issues.

Thanks for reporting this.


I'll probably remove mpv --version check, as iirc it was intended
for really old mpv by now (must be something like 10yo versions),
where such "fifo" method was the only one supported, which can
surely be dropped by now, addressing at least one of the issues here.


-- 
Mike Kazantsev // fraggod.net