Re: log-view-diff

[Juri Linkov]

>  > What about the following docstring?  It should correctly document what
>  > this function does.
>
> Why require mark to abe active?

Actually, it doesn't require mark to be active.  When mark is not active,
it uses the revision at point.

> After all, only the end points are of interest not the region in
> between so it could work like dired-diff in this respect.

`region-beginning' always returns the minimum position of point or mark,
`region-end' returns the maximum position of point or mark.  Those are
more convenient functions than using `point' and `mark' and compare
their values by `min' and `max' to find the lowest and highest end point.

`mark-active' is useful in this function for transient-mark-mode,
because end points are only meaningful if the mark is active in
transient-mark-mode.

Unlike dired-diff, where the order of the marked file and the file at point
can be reversed if needed, in log-view-diff the order is fixed with
the more recent revision always going to the second argument of
`vc-version-diff', and the older revision to its first argument.

BTW, dired-diff has a significant inconvenience.  I will send a separate
patch for it.

-- 
Juri Linkov
http://www.jurta.org/emacs/