Re: [PATCH] Bugs in lisp/hl-line.el.

[Lute Kamstra]

"Stefan Monnier" <monnier+gnu/emacs/address@hidden> writes:

[...]

> You can remove lambda expressions from hooks.  The equality test
> uses `equal' AFAIK.

Ah, yes.  That's possible indeed.  I didn't know that.

>> I'm in favor of letting the define-minor-mode macro generate
>> turn-on-minor-mode and turn-off-minor-mode functions automatically.
>
> The turn-mode-off function would be virtually never used.  And the
> toggling behavior is also basically never used either.  So my Emacs
> just uses foo-minor-mode as turn-mode-on function (the toggling
> behavior still works interactively because it passes a `toggle'
> argument).  This fixes the bug where users do (add-hook 'foo-mode
> 'bar-minor-mode) without realizing that it might turn the mode off.

This is probably a good idea for new users.  For folks venturing a
little bit further into Emacs Lisp territory, this can be confusing as
calling the command without an argument behaves interactively
differently from non-interactively.  I guess a good docstring would
make most confusion go away, though.

By the way, I just noticed that the define-minor-mode macro as shipped
with Emacs 21.2 and 21.3 produces minor modes that disregard prefix
arguments when called interactively.  Invoking the minor mode command
interactively always toggles.  Is this intentional?  With Emacs 21.1
and current 21.3.50, the produced minor modes do take prefix arguments
into account.

> But this apparently incompatible change is not very popular among
> emacs-devel crowd, it seems :-(
>
>> Shall it write a new patch, one that does the same as my previous
>> patch, but leaves the test for hl-minor-mode intact?
>
> Do you have write access to the repository ?

No.

> If not, you probably should try and get it since IIRC you have
> signed the relevant paperwork already.

Yes, I did sign the necessary copyright papers.  How do I go about
getting write access?  Create an account on Savannah, ask a maintainer
to add me to the emacs project, and then registers an SSH1 key?

Lute.

-- 
Lute Kamstra  <address@hidden>
CWI  department PNA4
Room M233  phone (+31) 20 592 4214
[Echelon material: NWO Reno plutonium]