[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add next-error support to org-lint report buffer
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH] Add next-error support to org-lint report buffer |
Date: |
Thu, 02 Jan 2025 19:09:50 +0000 |
Malcolm Purvis <malcolm@purvis.id.au> writes:
> Thanks for the review and happy new year..
>
>>> -| {{{kbd(S)}}} | Sort reports by the column at point |
>> Looks like you deleted this line by accident.
>
> I've restored this in the patch below.
I think you can simply squash the fix with the original patch.
>> I just tried your patch on an Org file with 2 warnings and tried
>> to press C-x ` repeatedly. Upon moving to the last line in *Org
>> lint* buffer, I got
>
> This is a bug in the original org-lint code, where this error was
> raised it you pressed <RET> on the line after the list in the
> report. The next error code just did the same thing.
>
> I've included a fix for that to ignore requests to just to the
> source when not in the list of errors.
Thanks!
This indeed fixed the problem I described.
There is another problem though.
Consider:
1. M-x org-lint
2. Switch back to the original .org buffer
3. M-g M-n
4. Observe link report and .org window swapped and point moving back to
the lint report. It is not what usually happens with error navigation
(e.g. during compile or grep navigation)
> +| {{{kbd(C-x `)}}} | Move to the next report and display the
> offending line |
May as well mention M-g M-n and maybe `previous-error' (M-g M-p)
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>