Re: [PATCH] Texinfo: Check for math support without warnings and quietly (was: Improve Texinfo math checking)

[Rudolf Adamkovič]

A friendly ping. :)

Rudolf Adamkovič <rudolf@adamkovic.org> writes:

> Oops, I found a bug in the patch.
>
> Now fixed.
>
> Rudy
> From a99cb0ecafb6a0a1d4ef841dd20be5fa2da43cff Mon Sep 17 00:00:00 2001
> From: Rudolf Adamkovic <rudolf@adamkovic.org>
> Date: Tue, 27 Aug 2024 11:10:56 +0200
> Subject: [PATCH] ox-texinfo: Check for math support without warnings and
>  quietly
>
> * lisp/ox-texinfo.el (org-texinfo-supports-math-p): Two
> improvements: (1) Fix the incorrect `.info' extension used for the
> temporary `.texi' file.  This removes the warning "makeinfo: warning:
> input file testXXX.info; did you mean testXXX.texi?" (2) Suppress
> output when compiling the "Is math supported?" test file.  This is to
> avoid user confusion, as the user cares about their Texinfo file, not
> implementation details.  This removes the message "Processing Texinfo
> file /var/.../testXXX.info...".
> ---
>  lisp/ox-texinfo.el | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/lisp/ox-texinfo.el b/lisp/ox-texinfo.el
> index 6adee9fca..b11808ed5 100644
> --- a/lisp/ox-texinfo.el
> +++ b/lisp/ox-texinfo.el
> @@ -2037,9 +2037,12 @@ Once computed, the results remain cached."
>    (unless (boundp 'org-texinfo-supports-math--cache)
>      (setq org-texinfo-supports-math--cache
>            (let ((math-example "1 + 1 = 2"))
> -            (let* ((input-file (make-temp-file "test" nil ".info"))
> +            (let* ((input-file (make-temp-file "test" nil ".texi"))
> +                   (output-file
> +                    (file-name-with-extension
> +                     (file-name-sans-extension input-file) "info"))
>                     (input-content (string-join
> -                                   (list (format "@setfilename %s" 
> input-file)
> +                                   (list (format "@setfilename %s" 
> output-file)
>                                           "@node Top"
>                                           "@displaymath"
>                                           math-example
> @@ -2050,7 +2053,8 @@ Once computed, the results remain cached."
>                (when-let* ((output-file
>                             ;; If compilation fails, consider math to
>                             ;; be not supported.
> -                           (ignore-errors (org-texinfo-compile input-file)))
> +                           (ignore-errors (let ((inhibit-message t))
> +                                            (org-texinfo-compile 
> input-file))))
>                            (output-content (with-temp-buffer
>                                              (insert-file-contents 
> output-file)
>                                              (buffer-string))))
> -- 
> 2.39.3 (Apple Git-146)
>
> -- 
> "I love deadlines.  I love the whooshing noise they make as they go by."
> --- Douglas Adams, The Salmon of Doubt, 2002
>
> Rudolf Adamkovič <rudolf@adamkovic.org> [he/him]
> http://adamkovic.org

-- 
"One can begin to reason only when a clear picture has been formed in
the imagination."
--- Walter Warwick Sawyer, Mathematician's Delight, 1943

Rudolf Adamkovič <rudolf@adamkovic.org> [he/him]
http://adamkovic.org