emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Cannot yank media when image come from Gnome screenshot


From: Robert Pluim
Subject: Re: Cannot yank media when image come from Gnome screenshot
Date: Mon, 05 Aug 2024 21:03:44 +0200

>>>>> On Mon, 05 Aug 2024 17:44:43 +0000, Ihor Radchenko <yantar92@posteo.net> 
>>>>> said:

    Ihor> Robert Pluim <rpluim@gmail.com> writes:
    >>>>>>> On Sun, 04 Aug 2024 19:01:24 +0000, Ihor Radchenko 
<yantar92@posteo.net> said:
    >> 
    Ihor> I am not sure if I like patching Emacs functions when loading Org 
mode.
    Ihor> On the other hand, I do not see any obvious downside.
    >> 
    >> I was hoping you始d have a strong opinion 馃榾

    Ihor> Generally speaking, defining global methods is a very bad practice.
    Ihor> But I feel that it _might_ be justified in this particular case.

It始s a specialised global method, so it始s not too bad

    Ihor> Robert, what do you think about such idea? 
    >> 
    >> It始s a cl-defmethod that I assume you will hide behind a version
    >> check, and the changed code itself should only run for a pgtk emacs,
    >> so I don始t see a great risk. And in the absolute worst case
    >> `yank-media' doesn始t work, which is the situation we already have.

    Ihor> Yes, behind version check, pgtk build check, and, ideally, after
    Ihor> checking that such method is not yet defined.

The cl-defmethod itself checks it始s being run in a pgtk emacs, so not
sure we need more than that.

    Ihor> May you create such a patch against Org mode repository?

This week I am a bit busy, so not before middle of next week at the
earliest.

Robert
-- 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]