emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] [BUG] Support attr_html in source code and fixed-width block


From: Suhail Singh
Subject: Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks
Date: Mon, 22 Jul 2024 15:35:25 -0400
User-agent: Gnus/5.13 (Gnus v5.13)

Ihor Radchenko <yantar92@posteo.net> writes:

> AFAIU, your main point is that you want the patch to land on bugfix. It
> will not, regardless whether we add :textarea support or not.

While not the answer I had hoped for, I appreciate the clarification.

> Next, if you are not interested in adding :textarea support, it is
> OK. Adding #+ATTR_HTML support for code blocks and fixed width elements
> will still be a welcome improvement (I was just hoping to push you to
> contribute a bit more ;))
>
> Now, back to your original patch.
> May you please factor out adding attributes into a separate function, so
> that we avoid duplicating the code? And please announce the change in
> the news - people aware of the current behavior might need to know about
> the change.

Given that I already have some contributions in Org mode and I don't, at
present, intend to do the copyright assignment to FSF, could you please
confirm:

1. How many lines worth of changes I can still introduce without going
   over the limit?

2. When implementing such refactoring changes, which lines are counted?

>From a feasibility perspective, I suspect it might be better for you (or
someone else who's signed the FSF copyright assignment paperwork) to
take on the work of applying changes that are similar in spirit to the
patch.

-- 
Suhail



reply via email to

[Prev in Thread] Current Thread [Next in Thread]