Re: org-encrypt-entries is slow (was: org-crypt leaking data when encryption password is not entered twice (was: Please document the caching and its user options))

[Daniel Clemente]

> May you try
> https://git.sr.ht/~yantar92/org-mode/log/feature/org-crypt-refactor branch?
> Is encryption speed satisfactory then?

With that code I see something strange: I opened a file which had
encrypted :crypt: sections (never unencrypted), and after adding a
space somewhere else and saving, it asked me for an encryption
password. It shouldn't, since all sections are encrypted.
I also see „org-crypt: Re-encrypting all decrypted entries due to
auto-save“ asking me for the encryption password.

But I tried removing all :crypt: tags (I renamed them to something
else), and saving a large file seems as slow as before. A few seconds
(often 5 seconds; sometimes it's just 2 or 3; this was the case before
too). Here's when it's 5, for 1 save:

        4669  82% - command-execute
        4076  72%  - funcall-interactively
        4055  72%   - save-buffer
        4051  71%    - basic-save-buffer
        3831  68%     - run-hook-with-args-until-success
        3831  68%      - org-crypt--encrypt-and-mark-entries
        3831  68%       - org-encrypt-entries
        3831  68%        - org-scan-tags
        3831  68%         - org-element-cache-map
        1859  33%          - org-element--parse-to
         848  15%           + org-element--cache-put
         655  11%           + #<native-comp-function
F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_38>
         120   2%           + org-element--cache-find
          28   0%             org-element--cache-active-p
          20   0%             #<native-comp-function
F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_12>
          16   0%             org-element-type
           4   0%             #<native-comp-function
F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_18>
           4   0%             #<native-comp-function
F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_15>
        1100  19%          - #<byte-code-function A8A>
         804  14%           - org-entry-get-with-inheritance
         780  13%            - org-element-lineage-map
         720  12%             - #<byte-code-function A27>
         668  11%              + org--property-local-values
          12   0%                org-element-begin
           4   0%                delq
          36   0%             + org-element--property
           8   0%             + org-element-type-p
           4   0%               functionp
           8   0%              org--property-get-separator
           8   0%              make-closure
         208   3%           + org-element--property
          32   0%           + org-get-tags
           8   0%           + org-element-begin
         384   6%          + org-element-at-point
         164   2%            re-search-forward
         132   2%          + #<native-comp-function
F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_66>
          44   0%          + #<native-comp-function
F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_9>
          16   0%            match-data
          12   0%          + org-element--property
           8   0%          + #<byte-code-function A02>
           8   0%            make-closure
           4   0%            buffer-base-buffer
           4   0%          + org-element-type-p
         220   3%     + basic-save-buffer-1
           8   0%     execute-extended-command
           6   0%   + org-delete-backward-char
           3   0%   + org-self-insert-command
           3   0%   + previous-line
           1   0%   + next-line
         593  10%  - byte-code


I also see new problems (which would take me a long time to explain
since I don't understand the code or the settings), where:
- Org asks me for an encryption password even if there are no :crypt:
tags. I just changed the only :crypt: tag to a :nocrypt: tag and saved
- Org spends around 20 seconds trying to save the file, in a loop,
reporting:  (error "org-crypt: Encryption failed.  Not saving the
buffer. Error: GPG error: \"Encrypt failed\", \"Canceled; Exit\"")