emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [BUG/FR] org-plot: replot on resize [9.7-pre (N/A @ /home/viz/lib/em


From: Ihor Radchenko
Subject: Re: [BUG/FR] org-plot: replot on resize [9.7-pre (N/A @ /home/viz/lib/emacs/straight/build/org/)]
Date: Sat, 15 Jun 2024 13:37:44 +0000

Visuwesh <visuweshm@gmail.com> writes:

>> So, you can set DATA to (list (or dump-func 'org-plot/gnuplot-to-data) table 
>> num-cols params)
>
> Done in the attached patch.

Thanks!

>        ;; Dump table to datafile
> -      (let ((dump-func (plist-get type :data-dump)))
> +      (let* ((dump-func (plist-get type :data-dump)))

Why let*?

> +        (setq data-file (org-babel-temp-stable-file
> +                         (list (or dump-func 'org-plot/gnuplot-to-data)
> +                               table num-cols params)
> +                         "org-plot"))

Please add in-code comment explaining why we need `org-babel-temp-stable-file'.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]