Re: [PATCH] Fix regex for determining image width from attribute

[Ihor Radchenko]

Max Nikulin <manikulin@gmail.com> writes:

>> 1. #+attr_org is prioritised
>
> I ma afraid, the code is a bit fragile. Consider
>
> #+attr_html: :alt Image width test
> #+attr_beamer: :width \linewidth
> #+attr_latex: :width +.5\textwidth
> #+attr_md: :width 75%
> [[file:babelfish.png]]
>
> - I do not mind that just "\linewidth" is ignored.
> - The case of "+.5" should either be supported or at least documented 
> since it is a valid floating number.

Was it supported before?

> - It is really confusing that #+attr_html casts shadow on #+attr_md.

No, it is not. I see no reason to prioritize markdown attributes.

>> +++ b/etc/ORG-NEWS
>> @@ -13,6 +13,18 @@ Please send Org bug reports to 
>> mailto:emacs-orgmode@gnu.org.
> ...
>
> I think, it is better to avoid "is ignored" here.
>
> Previously, when ~org-image-actual-width~ is a list or nil,
> Org used the first =#+attr_...= keyword containing =:width ...=
> to compute the inline image width.
> Now, =#+attr_org=, if present, takes precedence.
> In the following example the image preview has width of 70%
> while earlier versions take 33%.
>
> : #+attr_html: :width 33%
> : #+attr_org:  :width 0.7
> : [[image.png]]

May you convert your suggestion into a patch?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>