Re: [PATCH] Autoload `org-assert-version' and remove org-loaddefs.el

[Ihor Radchenko]

Max Nikulin <manikulin@gmail.com> writes:

> On 29/03/2023 20:38, Ihor Radchenko wrote:
>> Even though we identified that the problem is related to a combination
>> of old Emacs version and OS-specific Emacs customization
>
> Ihor, who should notice improvement due to this patch? Is it related to 
> Emacs-29.1 release? The issue is weird, but on the other hand I do not 
> remember complains on the mailing list last months (besides some period 
> close to the Org release).
>
> Sorry, I have not tried to compile Emacs myself and I am really puzzled 
> why you was not able to reproduce the issue. So from my point of view it 
> is unlikely related to distribution-specific configuration or patches. 
> Changes related to `package--reload-previously-loaded` sound more 
> reasonable for me.

I was able to reproduce on Debian using virtual machine.
Also, several people were able to reproduce in Matrix when I asked them.
And we got one report from Fedora user. + Several from Ubuntu users.
Recently, there was also
https://old.reddit.com/r/orgmode/comments/123qnqq/workaround_for_orgassertversion_problem_not/

It is natural that we are getting fewer reports away from the release,
after most people upgraded Org. Now, most of the affected users are the
new users trying to install Org after installing Emacs. These users are
much less likely to report bugs.

> I am in doubts if emacs version should be checked or it should be e.g. 
> (fboundp 'org-assert-version).

It is indeed a cleaner approach.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>