emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] org--batch-store-agenda-views: Fix treatment of lambda functions


From: Aaron L. Zeng
Subject: [PATCH] org--batch-store-agenda-views: Fix treatment of lambda functions
Date: Mon, 6 Feb 2023 20:05:34 -0500

`org-agenda-custom-commands' entries may specify a custom function
instead of a symbol like `tags-todo'.  `org--batch-store-agenda-views'
behaved differently from `org-agenda' when that custom function was
defined as a lambda rather than a symbol, incorrectly treating the
lambda form as a list of agenda commands.

This patch makes `org--batch-store-agenda-views' use the same test as
`org-agenda' does to determine whether the command is a series.
---
 lisp/org-agenda.el | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 1d1f2271b..1aab64820 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -3525,7 +3525,8 @@ This ensures the export commands can easily use it."
   (let ((cmds (org-agenda-normalize-custom-commands 
org-agenda-custom-commands))
         (pop-up-frames nil)
         (dir default-directory)
-        cmd thiscmdkey thiscmdcmd match files opts cmd-or-set bufname)
+        cmd thiscmdkey thiscmdcmd match files opts cmd-or-set
+        seriesp bufname)
     (save-window-excursion
       (while cmds
        (setq cmd (pop cmds)
@@ -3538,8 +3539,9 @@ This ensures the export commands can easily use it."
                              (format "*Org Agenda(%s)*" thiscmdkey))
                        org-agenda-buffer-name)
              cmd-or-set (nth 2 cmd)
-             opts (nth (if (listp cmd-or-set) 3 4) cmd)
-             files (nth (if (listp cmd-or-set) 4 5) cmd))
+             seriesp (not (or (symbolp cmd-or-set) (functionp cmd-or-set)))
+             opts (nth (if seriesp 3 4) cmd)
+             files (nth (if seriesp 4 5) cmd))
        (if (stringp files) (setq files (list files)))
        (when files
          (let* ((opts (append org-agenda-exporter-settings opts))
-- 
2.38.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]