emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.


From: No Wayman
Subject: Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)]
Date: Fri, 20 Jan 2023 12:34:08 -0500
User-agent: mu4e 1.9.14; emacs 30.0.50


Ihor Radchenko <yantar92@posteo.net> writes:

No Wayman <iarchivedmywholelife@gmail.com> writes:

Feel free to take this the patch as a base to do whatever you please with it.

Then, I am thinking about a simple approach that will not involve
internet connection. See the attached.

I think that's the best solution. I landed on something similar for Elpaca (and will likely suggest the same for straight.el).

Note that you, in fact, can fetch the latest tags from remote into
shallow clone. See
https://stackoverflow.com/questions/66349002/get-latest-tag-git-describe-tags-when-repo-is-cloned-with-depth-1

Seems more complicated than it's worth at this point.

   # Use the org.el header.
ORGVERSION := $(patsubst %-dev,%,$(shell $(BATCH) --eval "(require 'lisp-mnt)" \ --visit lisp/org.el --eval '(princ (lm-header "version"))')) - GITVERSION ?= $(shell git describe --match release\* --abbrev=6 HEAD) + GITVERSION ?= $(shell git describe --match release\* --abbrev=6 HEAD 2>/dev/null || echo "release_N/A-N/A-$(shell git log --format=%h HEAD^..HEAD)")

Why not use ORGVERSION here? Is the metadata in org.el's version header not updated when a commit is tagged as a release?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]