emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] org-attach.el: ID to path functions may return nil


From: Max Nikulin
Subject: Re: [PATCH v2] org-attach.el: ID to path functions may return nil
Date: Sun, 13 Nov 2022 23:26:49 +0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

On 10/11/2022 14:19, Ihor Radchenko wrote:
Max Nikulin writes:

P.S. At first I believed that you have some objections concerning
changed role of the first function in the list, not just how it is
documented.

I had. Most importantly, because we are changing the existing meaning of
`org-attach-id-to-path-function-list'. However, the only scenario where
it actually matters is the bug report at hand. So, there will be no
regression.

Since the change relaxes requirements for `org-attach-id-to-path-function-list' members, it should not be a breaking change. I have realized that it allows to mix e.g. UUID and timestamp IDs in the single file and still follow storage policy for each one. Earlier change of `org-id-method' caused subdirs for timestamps created like for UUID or vice versa. Actually with a cumbersome function it was possible earlier as well, but now particular ID to subdir functions may be unaware of other ID methods.

However, please add NEWS entry detailing the change in
`org-attach-id-to-path-function-list' to the next version of the patch.

See the attachment.

Attachment: v3-0001-org-attach.el-ID-to-path-functions-may-return-nil.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]