Re: [BUG] Undocumented convention for org-time-stamp-custom-formats to be "<...>"

[Uwe Brauer]

>>> "IR" == Ihor Radchenko <yantar92@posteo.net> writes:

> Uwe Brauer <oub@mat.ucm.es> writes:
>> My time-stamps are of the form <2022-10-23 Sun>
>> I have an entry like this 
>> 
>> - State "DONE"       from "WAIT"       [2022-10-23 21:06] \\
>> 
>> 
>> 
>> However it is displayed when I use org-toggle-time-stamp-overlays  as
>> [23.10.%]
>> 
>> Neither the year not the time is displayed, why!
>> 
>> I have set 
>> org-time-stamp-custom-formats 
>> to 
>> (" %d.%m.%Y " . " %d.%m.%Y")
>> 
>> I am puzzled, any ideas?

> Confirmed.

thanks

> This is because Org expects the first and the last characters in
> org-time-stamp-custom-formats to be opening/closing brackets.
> (undocumented)

So this should have been the correct setting?

("<%d.%m.%Y " . " %d.%m.%Y>")

> Why?
> Because org-time-stamp-formats does so.

> Why does org-time-stamp-formats does so?
> No idea.
> This code dates back to initial Org commits.

> I think it would make sense to change it.
> However, if we change special treatment of the first/last characters in
> org-time-stamp-custom-formats, it will also make sense to change
> org-time-stamp-formats constant.

> For backwards compatibility, we will need to keep special treatment to
> strip brackets around the formats, if present.

> I propose to do the following:
> 1. org-time-stamp-formats and org-time-stamp-custom-formats will be
>    treated as is, unless they contain "<" and ">" and the first and the
>    last char.
> 2. If the formats do contain <...>, strip the "<" and ">".
> 3. Document (2) in the docstrings.

> Any objections?

To me that sounds logical.



-- 
Warning: Content may be disturbing to some audiences
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 
https://addons.thunderbird.net/en-US/thunderbird/addon/gmail-conversation-view/

smime.p7s
Description: S/MIME cryptographic signature