emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [External] : Re: strange errors with org-element-cache-reset and jit


From: Ihor Radchenko
Subject: Re: [External] : Re: strange errors with org-element-cache-reset and jit-lock-function void-variable org-element-citation-prefix-re
Date: Fri, 23 Sep 2022 10:07:10 +0800

Daniel Ortmann <daniel.ortmann@oracle.com> writes:

> Was Eli Z's observation the key?  Of code not autoloading when 
> eval-buffer is running?

Yes, it is.

Bastien,
In f36b19eef, you introduced the following code into org.el:

(or (eq this-command 'eval-buffer)
    (condition-case nil
        (load (concat (file-name-directory load-file-name)
                      "org-loaddefs.el")
              nil t t t)
      (error
       (message "WARNING: No org-loaddefs.el file could be found from where 
org.el is loaded.")
       (sit-for 3)
       (message "You need to run \"make\" or \"make autoloads\" from Org lisp 
directory")
       (sit-for 3))))

The commit message explains why we display warning, but it is unclear
why (eq this-command ...) check is performed.

This check is causing the issue herein. Also, see
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57972

I am leaning towards removing `this-command' check, unless there are
important reasons to keep it.

-- 
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92



reply via email to

[Prev in Thread] Current Thread [Next in Thread]