Re: [PATCH] ol.el: Always prompt for description in `org-insert-link'

[Ihor Radchenko]

Max Nikulin <manikulin@gmail.com> writes:

> I have an idea how to fix the code to bypass the description prompt if 
> path is completed by description discarding identical path and 
> description, but I prefer to drop the confusing variable and not depend 
> on the means how the link was selected from the list of stored items.
>
> Have I missed something and unconditional prompt to edit link 
> description may be undesired in some cases?

AFAIU, this particular behaviour is undocumented. If it is used by some
other code, let's make tests for it, document, and fix in a better, more
explicit way.

I am unaware about the code using this link==description behaviour.

Applied onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=69b36beac790bad95fdd9ce4a7bcfbbb46d39c64
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6d8d7fba61652434764c9906df69db373ff4f7f6

Bastien,

Could you please check the ongoing changes in this area
(storing/inserting links)? The code in this area is old, confusing, and
not fully documented. I'm afraid that we may break something in the
process of refactoring. If you see some dangerous changes, please let us
know.

-- 
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92