Re: [PATCH 4] New: auto display inline images under subtree when `org-cycle'.

[Ihor Radchenko]

"Christopher M. Miles" <numbchild@gmail.com> writes:

>> Also, this change should be documented in etc/NEWS and also in
>> "12.7 Images" section of the manual.
>
> Done. (the manual, you mean org-manual.org right? I found too many
> documents under doc/ folder, confused for a while....)

I meant doc/org-manual.org
Note doc/Documentation_Standards.org for the conventions we use in the
manual. Your patch does not follow those conventions (double space
between sentences).

> P.S: I merged two commits into one for clear.

Let's not do it. They are two distinct changes and I will have
significant comments regarding subtree cycling. (I had plans to
implement <TAB> cycling at point for images, and we may as well take this
chance to create some generic infrastructure for showing/hiding the
inline images).

For now, lets sort out the ORG-IMAGE-ACTUAL-WIDTH property and get it
merges. Then, we can move ahead to the subtree cycling feature.

> * lisp/org.el (org-display-inline-image--width): support subtree-level
                                                  ^S

> +If you want to override global variable ~org-image-actual-width~ of
> +inline image display width, you can specify property
> +"=ORG-IMAGE-ACTUAL-WIDTH=" in subtree level. It will only affect
> +inline images under the specified subtree.

Could you also add a paragraph describing what org-image-actual-width
does?

> +*** New default property =ORG-IMAGE-ACTUAL-WIDTH= for overriding global 
> ~org-image-actual-width~

I think that people may be confused by "default property" here. Just say
"new property".

> +The subtree-level property "ORG-IMAGE-ACTUAL-WIDTH" can override the
> +global variable ~org-image-actual-width~ settings for inline images
> +width under current property specified subtree.

It is not necessarily subtree-level. You can as well set it in
document-wide property drawer. Just say "The new property ... overrides ...".

-- 
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92