Re: [PATCH v2] org.el: Fix percent substitutions in `org-open-file'

[Ihor Radchenko]

Max Nikulin <manikulin@gmail.com> writes:

> I have removed most parts of the example. In addition I fixed some 
> issues with references in the docstring (man mailcap is not recognized 
> as a link for some reason yet). I changed the function to consider 
> trailing backslash as a format error.

Thanks!
Applied onto main with minor amendments to punctuation in the docstrings.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=ac2d0a249e5419fb52bc1e953e70c847a31d40de

> I mean another problem. A user adds (require 'some-package) that defines 
> new link type. Later the user invokes easy customization interface to 
> adjust a link unrelated to some-package. At this step
> links from some-package are added to user's init file. Ideally it should 
> not happen and after removing of (require 'some-package) there should be 
> no link types from the package in the init file at all, including 
> customization section.
>
>  From my point of view entries added to `org-link-parameters', 
> `org-file-apps', etc. by packages should not affect entries managed 
> through customization.

Well. The situation with third-party packages overriding/changing
defcustoms is not uncommon in Emacs. For example, display-buffer-alist
is altered by shackle.

I think that the usual approach to mitigate this problem (when it is a
problem) is adding an auxiliary variable supplementing defcustom. Just
like `org-entities' and `org-entities-user'. Note that we actually do
have such auxiliary variables for `org-file-apps':
`org-file-apps-macos', `org-file-apps-gnu', and
`org-file-apps-windowsnt'. They are currently declared as constants, but
we may change it - there is no strong reason to disallow altering those
OS-specific variables.

-- 
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92