emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Potential bug: Invalid function: org-encode-time


From: Ihor Radchenko
Subject: Re: Potential bug: Invalid function: org-encode-time
Date: Tue, 16 Aug 2022 20:51:43 +0800

> Testing of `encode-time' version by running it on
each macro expansion can hardly be called optimal.

It will mostly impact the compile time. If you wish, you may wrap the version check and the `encode-time' test into `eval-when-compile'

On Tue, Aug 16, 2022 at 8:44 PM Max Nikulin <manikulin@gmail.com> wrote:
On 16/08/2022 18:55, Ihor Radchenko wrote:
> Max Nikulin writes:
>
>>> This is Emacs bug. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56746
>>>
>>> I just pushed a workaround that should hopefully fix the issue.
>>
>> Is there a chance that `eval-when-compile' around the original
>> definition will help? Sorry, I am still avoiding setting up of
>> development environment for emacs.
>
> It could, but I took a different approach.
> See https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=d3a9c424ba32382fff1da4f4ecb447dc99205261

Thank you for the fix. I asked about `eval-when-compile' because lack of
it may be my mistake and with hope to find a workaround with no
performance impact. Testing of `encode-time' version by running it on
each macro expansion can hardly be called optimal.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]