emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] lisp/ob-plantuml.el: Insert results in buffer


From: Ihor Radchenko
Subject: Re: [PATCH v2] lisp/ob-plantuml.el: Insert results in buffer
Date: Fri, 05 Aug 2022 13:15:23 +0800

Joseph Turner <joseph@breatheoutbreathe.in> writes:

> When :results header arg is set to a value that doesn't include
> "file", insert txt output in buffer below src block.

This looks reasonable. Thanks!

> -  (let* ((out-file (or (cdr (assq :file params))
> -                    (error "PlantUML requires a \":file\" header argument")))
> +  (let* ((do-export (member "file"
> +                            (split-string (cdr (assq :results params)))))

Let's take this opportunity and fix another omission in ob-plantuml.
:results may generally contain Elisp sexps to be evaluated and the whole
split-string busyness is not accurate. Please use :result-params list
instead of :results.

Also, can you please update the ob-plantuml documentation according to
the changes made. The current version is in
https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-plantuml.html

You will need to create a patch against
https://git.sr.ht/~bzg/worg/tree/master/item/org-contrib/babel/languages/ob-doc-plantuml.org
repo.

Best,
Ihor



reply via email to

[Prev in Thread] Current Thread [Next in Thread]