[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] org-test: Run all ol tests on make test
|
From: |
Ihor Radchenko |
|
Subject: |
Re: [PATCH] org-test: Run all ol tests on make test |
|
Date: |
Thu, 28 Jul 2022 22:31:51 +0800 |
Max Nikulin <manikulin@gmail.com> writes:
> On 27/07/2022 10:49, Ihor Radchenko wrote:
>>
>> You missed the
>>
>> (org-test-selector
>> (if org-test-selector org-test-selector "\\(org\\|ob\\)"))
>
> I have notices that cases in test-oc.el are named test-org-cite/... So I
> am considering renaming tests in test-ol.el in the same way from
> test-ol/... to test-org-link/... instead of modifying selectors. I have
> not noticed with approach to naming is recommended.
Either way is fine. Ideally, we should stick to org- prefix, as expected
from Elisp conventions. But we are already kind of breaking this
convention by having all the oc- ol-, etc files.
Best,
Ihor