emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Poly


From: Kai von Fintel
Subject: Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists
Date: Sat, 23 Jul 2022 17:39:34 +0300


On 23 Jul 2022, at 17:22, Ihor Radchenko wrote:

> Kai von Fintel <fintel@mit.edu> writes:
>
>>>>> Debugger entered--Lisp error: (void-variable 
>>>>> org-latex-babel-language-alist)
>>>>>  org-latex--format-spec(
>>>
>>> org-latex-babel-language-alist is the new variable introduced in the
>>> patch. You seem to be loading "mixed" Org versions - built-in + latest.
>>
>> No, I’m looking just at the HEAD version of =ox-latex.el= at 
>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/lisp/ox-latex.el
>>
>> The new variable is =org-latex-language-alist=, defined on line 175f.
>>
>> But, =org-latex—format-spec=, defined on line 1860ff, uses the old variable 
>> names:
>>
>> (defun org-latex--format-spec (info)
>>   "Create a format-spec for document meta-data.
>> INFO is a plist used as a communication channel."
>>   (let ((language (let ((lang (plist-get info :language)))
>>                  (or (cdr (assoc-string lang org-latex-babel-language-alist 
>> t))
>>                      (nth 1 (assoc-string lang 
>> org-latex-polyglossia-language-alist t))
>>                      lang))))
>>
>> This borks my latex exports.
>
> This is unrelated to the error you are seeing. void-variable error is
> thrown for org-latex-babel-language-alist, so I still suggest checking
> the place in your config where you are loading Org.
>
> However, you did raise an important omission in the patch - the variable
> value was lost in the patch. It was not supposed to happen. I now
> restored (in 127e7fee4) the defconst statements and moved them into
> org-compat.el. Thus, they can be used by third-party code for the time
> being.

Thanks, Ihor. Your change fixed my issue.

I do think that the code on lines 1864 and 1865 of =ox-latex.el= 
(https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/lisp/ox-latex.el#n1864)
 should not use the old variable names. Since you’ve now defined the old 
variables in =org-compat.el=, my exports work, so I’m ok for the moment. But I 
don’t understand why they are still used in the definition of 
=org-latex--format-spec=.

But of course I’m far from familiar with the org code base.

— Kai.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]