emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [BUG] org-agenda-prepare-buffers does not save restrictions


From: Ihor Radchenko
Subject: Re: [BUG] org-agenda-prepare-buffers does not save restrictions
Date: Sat, 09 Jul 2022 11:57:43 +0800

Al Haji-Ali <abdo.haji.ali@gmail.com> writes:

> On 08/07/2022, Ihor Radchenko wrote:
>> Could you please create a proper patch
>
> See attached. I made a further change to use `with-current-buffer` instead of
> `set-buffer+save-excursion`.

Thanks!
Two more comments.

> * lisp/org.el (org-agenda-prepare-buffers): Call
> `save-restriction'/`save-excursion' for every buffer in the agenda
> instead of just once for the current buffer. Use `with-current-buffer'
> instead of `set-buffer'/`save-excursion'.

Please use double space between sentences.

> +          (save-excursion
> +            (save-restriction
> +              (widen)

A more concise way is

(org-with-wide-buffer ...)

Best,
Ihor



reply via email to

[Prev in Thread] Current Thread [Next in Thread]