emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] worg - Reflect the removal of org-mac-link.el from org-contr


From: Ihor Radchenko
Subject: Re: [PATCH] worg - Reflect the removal of org-mac-link.el from org-contrib
Date: Thu, 30 Jun 2022 15:39:54 +0800

Aimé Bertrand <aime.bertrand@macowners.club> writes:

> org-mac-link was removed from org-contrib with 
> https://git.sr.ht/~bzg/org-contrib/commit/c6aef31ccfc7c4418c3b51e98f7c3bd8e255f5e6.
>
> This is a patch (attached) for Worg to reflect the changes.

Thanks for the patch!

> --- a/org-contrib/index.org
> +++ b/org-contrib/index.org
> @@ -110,14 +110,6 @@ the package -- it will hopefully have some documentation.
>    Written by /Christopher Suckling/.
>    [[contribfile:lisp/org-mac-iCal.el][Link to raw file]].
>  
> -- [[file:org-mac-link.org][/org-mac-link.el/ -- grab links from various mac 
> applications]] ::
> -  Grab the current link or selection from an open mac application and
> -  insert it as a hyperlink at point in an org-mode document. Written
> -  by /Anthony Lander/, /John Wiegley/ and /Christopher Suckling/.
> -  This file replaces the earlier org-mac-message.el and
> -  org-mac-link-grabber.el.
> -  [[contribfile:lisp/org-mac-link.el][Link to raw file]].

Rather than removing the package description completely, it should be
moved to the External section.

> diff --git a/org-contrib/org-mac-link.org b/org-contrib/org-mac-link.org
> deleted file mode 100644
> index 2b2582e9..00000000
> --- a/org-contrib/org-mac-link.org
> +++ /dev/null

I have looked into README.org in
https://gitlab.com/aimebertrand/org-mac-link and I notice that it
contains less information compared to org-mac-link.org. It would be
useful to provide the missing details in the new README.org if you plan
to maintain the documentation there instead of WORG.

> -** [[file:org-contrib/org-mac-link.org][org-mac-link]] -- Hyperlink to items 
> in mac applications
> -   grab the current link or selection from an open mac application and
> -   insert it as a hyperlink at point in an org-mode document. Written
> -   by /Anthony Lander/.
> -
>  ** [[file:org-contrib/org-mac-mail-link.org][org-mac-mail-link]] -- 
> Hyperlink to messages in Mail.app
>     A small elisp file that addresses linking to Mail.app messages
>     directly via the =org-capture= system. For wider application
> -   support check out [[file:org-contrib/org-mac-link.org][org-mac-link]].
> +   support check out 
> [[https://gitlab.com/aimebertrand/org-mac-link][org-mac-link]].

[[file:org-contrib/org-mac-mail-link.org][org-mac-mail-link]] is not
changed and will become dead line after applying this patch.

Best,
Ihor



reply via email to

[Prev in Thread] Current Thread [Next in Thread]