[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature bra
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch |
Date: |
Thu, 21 Apr 2022 14:01:22 +0800 |
Bastien <bzg@gnu.org> writes:
> I'm on commit e0abbbacf9427b69482c6c47c3ea0975b0e6fa6d from the
> feature/org-fold-universal-core branch of your org repo.
>
> Using Emacs 29.0.50 and this as the content for ~/test.org:
>
> * TODO [[https://orgmode.org][test]]
> SCHEDULED: <2022-04-20 mer.>
>
> Then run:
>
> - emacs -q
> - C-x C-f test.org
> - M-x org-agenda RET
> - < a . n t
>
> You should see the link losing its invisibility specs.
I did see it in fork/feature/org-fold-universal-core and it is very
strange. The properties are suddenly lost after running
add-text-properties and things become normal if I simply move
add-text-properties above org-fold-region in
org-activate-links--text-properties.
What is more strange, the actual patch I proposed
(fork/feature/org-fold-universal-core-tidy) does not have the problem.
At least, I cannot reproduce it with you recipe. And the patch have
exactly same org-activate-links--text-properties...
Since the actual patch does not have the problem, I'd prefer to ignore
this problem unless it appears again after merging.
Best,
Ihor
- [PATCH v2 31/38] org-fold-core: Fix fontification inside folded regions, (continued)
- [PATCH v2 31/38] org-fold-core: Fix fontification inside folded regions, Ihor Radchenko, 2022/04/20
- [PATCH v2 33/38] org--string-from-props: Fix handling folds in Emacs <28, Ihor Radchenko, 2022/04/20
- [PATCH v2 34/38] org-link-make-string: Throw error when both LINK and DESCRIPTION are empty, Ihor Radchenko, 2022/04/20
- [PATCH v2 35/38] test-ol/org-toggle-link-display: Fix compatibility with old Emacs, Ihor Radchenko, 2022/04/20
- [PATCH v2 36/38] org-macs.el: Fix fontification checks take 2---, Ihor Radchenko, 2022/04/20
- [PATCH v2 37/38] org-fold-core-fontify-region: Fix cases when fontification is not registered, Ihor Radchenko, 2022/04/20
- [PATCH v2 38/38] org-agenda.el: Re-enable native compilation* lisp/org-agenda.el: Re-enable native compilation as it does not, Ihor Radchenko, 2022/04/20
- Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch, Bastien, 2022/04/20
Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch, Kévin Le Gouguec, 2022/04/22
Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch, Ihor Radchenko, 2022/04/25