emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Removing obsolete function `org-truely-invisible-p'.


From: Ihor Radchenko
Subject: Re: Removing obsolete function `org-truely-invisible-p'.
Date: Mon, 04 Apr 2022 19:55:58 +0800

Karl Fogel <kfogel@red-bean.com> writes:

>>Could you prepare a patch? Having a patch may encourage more 
>>feedback.
>
> Sure; please see attached.

Thanks! Marking your message as a patch to be tracked at
updates.orgmode.org

> From bb229b4f8f78ae52962d7bc90c8b1d4993af8263 Mon Sep 17 00:00:00 2001
> From: Karl Fogel <kfogel@red-bean.com>
> Date: Thu, 31 Mar 2022 19:02:38 -0500
> Subject: [PATCH] Mark function obsolete & fix spelling of its name

This commit message is a bit confusing. I would mention the function
name: "Mark `org-truely-invisible-p' obsolete and fix spelling of its
name"

> * lisp/org-macs.el (org-truely-invisible-p): Move to...
> * lisp/org-compat.el (org-truly-invisible-p): ...here, and add...
>   (org-truely-invisible-p): ...this compatibility alias.

It is too much.
We can either
1. Obsolete org-truely-invisible-p. Then, there is not much point
   renaming it.
2. Rename it without obsoletion. Then, there is not much point moving
   the function definition to org-compat.

>   From: Ihor Radchenko
>   Subject: Re: Removing obsolete function `org-truely-invisible-p'.
>   To: Karl Fogel
>   Cc: Org Mode
>   Date: Sun, 19 Dec 2021 17:14:32 +0800
>   Message-ID: <87h7b5rm6f.fsf@localhost>

I usually just leave an ML link in such cases:
https://orgmode.org/list/87h7b5rm6f.fsf@localhost

Best,
Ihor



reply via email to

[Prev in Thread] Current Thread [Next in Thread]