[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] org-refile.el: show refile targets with doc. title
From: |
Mikhail Skorzhinskii |
Subject: |
Re: [PATCH] org-refile.el: show refile targets with doc. title |
Date: |
Tue, 28 Dec 2021 12:59:09 +0100 |
User-agent: |
Evolution 3.40.4-1 |
Hi Ihor,
Thank you for reviewing the changes. Sorry for the sloppy patch, I've
retested everything and added a few additional fixes, there were more
problems.
I've added a couple of test cases too. (BTW, test framework is awesome
and really easy to use!)
I've attached new patch to this email. Let me know what you think.
Thanks,
Mikhail
On Sun, 2021-12-26 at 21:59 +0800, Ihor Radchenko wrote:
> Mikhail Skorzhinskii <mskorzhinskiy@eml.cc> writes:
>
> > * lisp/org-refile.el (org-refile-use-outline-path): add an option
> > 'title
>
> This is an interesting idea. However, your patch may break things
> quite
> badly. Look at `org-refile-get-location'. It expects a very specific
> format for the refile targets and treats 'file/'full-file-path values
> specially.
>
> Can you add tests for your new value of org-refile-use-outline-path
> and
> make sure that they do not fail after applying your patch?
>
> Best,
> Ihor
>
>
0002-org-refile.el-show-refile-targets-with-doc.-title.patch
Description: Text Data