[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Accept more :tangle-mode specification forms
From: |
Greg Minshall |
Subject: |
Re: [PATCH] Accept more :tangle-mode specification forms |
Date: |
Sun, 21 Nov 2021 07:08:16 +0300 |
hi, Timothy,
> I’ve just pushed three commits that
> 1. Add “o555” as an octal shorthand
> 2. Perform a simple check that integer modes are valid*
> 3. Make the ls-style regex stricter
> ...
> * For example, “:tangle-mode 755” will now produce the warning:
> “1363 is not a valid file mode octal. Did you give the decimal value 755 by
> mistake?”. Maybe it would be worth adding “if so try o755” or similar?
i'd push back, even here, on allowing decimal. file modes are bit
masks. to me, offering a way to set a bit mask via a *decimal* value
seems a mistake.
my +/- one cent.
cheers, Greg
- Re: [PATCH] Accept more :tangle-mode specification forms, (continued)
- Re: [PATCH] Accept more :tangle-mode specification forms, Timothy, 2021/11/18
- Re: [PATCH] Accept more :tangle-mode specification forms, Tom Gillespie, 2021/11/18
- Re: [PATCH] Accept more :tangle-mode specification forms, Tim Cross, 2021/11/19
- Re: [PATCH] Accept more :tangle-mode specification forms, tomas, 2021/11/19
- Re: [PATCH] Accept more :tangle-mode specification forms, Greg Minshall, 2021/11/19
- Re: [PATCH] Accept more :tangle-mode specification forms, Timothy, 2021/11/20
- Re: [PATCH] Accept more :tangle-mode specification forms, tomas, 2021/11/20
- Re: [PATCH] Accept more :tangle-mode specification forms, Timothy, 2021/11/20
- Re: [PATCH] Accept more :tangle-mode specification forms, tomas, 2021/11/20
- Re: [PATCH] Accept more :tangle-mode specification forms, Tim Cross, 2021/11/20
- Re: [PATCH] Accept more :tangle-mode specification forms,
Greg Minshall <=
- Re: [PATCH] Accept more :tangle-mode specification forms, Timothy, 2021/11/20
- Re: [PATCH] Accept more :tangle-mode specification forms, Greg Minshall, 2021/11/21
- Re: [PATCH] Accept more :tangle-mode specification forms, Tim Cross, 2021/11/20
- Re: [PATCH] Accept more :tangle-mode specification forms, Timothy, 2021/11/20
- Re: [PATCH] Accept more :tangle-mode specification forms, Tim Cross, 2021/11/21
- Re: [PATCH] Accept more :tangle-mode specification forms, Timothy, 2021/11/21
- Re: [PATCH] Accept more :tangle-mode specification forms, Timothy, 2021/11/29