Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken

[Max Nikulin]

On 08/10/2021 17:22, Marco Wahl wrote:
> Max Nikulin writes:
> > On 05/10/2021 23:32, Ihor Radchenko wrote:
> > > Max Nikulin writes:
> > > I tried come up with the reason why org-no-popup was used in the
> > > initial
> > > implementation. I think, the reason is avoiding situation like what you
> > > may see after running
> > > (let ((pop-up-frames t)) (funcall-interactively #'org-goto))
> > > So, removing the macro completely is not a good idea.
> > > I have updated the patch that should work without dropping the
> > > macro.
> > > See the attached.
>
> Please note the documentation of variable `pop-up-windows'.
>
>      This variable is provided mainly for backward compatibility and
>      should not be used in new code.
>
> The same holds for `pop-up-frames'.
>
> The drop of the macro looks like a good idea to me.  Can someone please
> describe the price for dropping macro `org-no-popups'?
>
> @Ihor I do not understand what "situation" you mean.

Marco, have you tried
  (setq pop-up-frames t)
with first version of patch? It shows help in a new separate frame. 
Unsure if it is expected behavior even with such customization.

However current version of macro does not protect against

  (setq display-buffer-base-action
        '((display-buffer-reuse-window display-buffer-pop-up-frame)
          (reusable-frames . 0)))

The example is taken from (info "(elisp) Choosing Window Options"). I 
have no idea if such customization can be considered as shooting a foot.

P.S.
http://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=399481bad10845a77f210c9320ff1efee9a312c8
that caused the current problem changed namely `pop-up-windows'

Joshua mentioned `display-buffer-overriding-action'.