[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix some typos
From: |
Marco Wahl |
Subject: |
Re: [PATCH] Fix some typos |
Date: |
Wed, 29 Sep 2021 13:09:05 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Max Nikulin <manikulin@gmail.com> writes:
> Bastien,
>
> A message in this thread
> 87tuiaxivh.fsf@posteo.net/">https://orgmode.org/list/87tuiaxivh.fsf@posteo.net/ (Juan Manuel
> Macías, Fri, 24 Sep 2021 12:23:14 +0000) contains a patch that fixes a
> Shakespeare's sonnet in org-manual.org
>
> Due to updated ORG-NEWS file, it could not be applied directly. I had
> it applied after
>
> commit d74a82448bc28dd9be7b57611038bbb4c7172bce
> Author: Sébastien Miquel <sebastien.miquel@posteo.eu>
> Date: Fri May 28 21:14:22 2021 +0200
>
> and in such form it could be rebased to main. Alternatively ORG-NEWS
> part could be just dropped (and applied later).
>
> The story is the following:
> - 91373e15c8 doc/org-manual.org 13905 (Juan Manuel Macías
> 2021-05-15 15:44:36 +0200 13906)
> a documentation for verse formatting was added with a strange variant
> (spread over net though)
> - 215d80d02b doc/org-manual.org 13907 (Stefan Kangas 2021-09-16
> 14:40:12 -0700 13909)
> besides other typos, one in this verse was fixed
> - 4271f228db doc/org-manual.org 13909 (Marco Wahl 2021-09-20
> 12:09:31 +0200 13909)
> reverted one edit by Stefan likely assuming old English spelling.
>
> Nobody has an idea concerning origin of current variant (particular
> edition of Shakespeare's book), so Juan Manuel created the patch with
> variant published in recent books.
>
> In https://orgmode.org/list/sin28h$ufv$1@ciao.gmane.io/
> I tried to add the following header
> X-Woof-Patch: org-manual.org, ORG-NEWS: fix Shakespeare' sonnet and
> another typo
> but the patch is not tracked currently on updates.orgmode.org
>
> On 25/09/2021 18:08, Marco Wahl wrote:
>> Juan Manuel Macías writes:
>>
>>> I attach a patch with Shakespeare's sonnet completely fixed: the poem is
>>> replaced by the version included in Wikipedia (Shakespeare, William.
>>> Duncan-Jones, Katherine. Shakespeare’s Sonnets. Bloomsbury Arden 2010.
>>> p. 113). I also removed a spurious phrase that I put in that patch
>>> (Org-News).
>> Thanks for the fix of the ORGNEWS entry. Nitpick: I'd prefer the
>> fix of
>> the ORGNEWS in a further patch for a little bit of more clarity.
>
> I agree with such remark, however I still suppose that the patch could
> be applied even in current variant.
Please go ahead with the patches as you like! That nitpick is meant as
a hint for commits to come!
Regards,
--
Marco
- Re: [PATCH] Fix some typos, (continued)
- Re: [PATCH] Fix some typos, Timothy, 2021/09/17
- Re: [PATCH] Fix some typos, Marco Wahl, 2021/09/17
- Re: [PATCH] Fix some typos, Stefan Kangas, 2021/09/17
- Re: [PATCH] Fix some typos, Max Nikulin, 2021/09/22
- Re: [PATCH] Fix some typos, Juan Manuel Macías, 2021/09/22
- Re: [PATCH] Fix some typos, Max Nikulin, 2021/09/23
- Re: [PATCH] Fix some typos, Loris Bennett, 2021/09/24
- Re: [PATCH] Fix some typos, Juan Manuel Macías, 2021/09/24
- Re: [PATCH] Fix some typos, Marco Wahl, 2021/09/25
- Re: [PATCH] Fix some typos, Max Nikulin, 2021/09/29
- Re: [PATCH] Fix some typos,
Marco Wahl <=
- Re: [PATCH] Fix some typos, Bastien Guerry, 2021/09/29
- Re: [PATCH] org-manual.org, ORG-NEWS: fix Shakespeare' sonnet and another, typo, Max Nikulin, 2021/09/25
- Re: [PATCH] Fix some typos, Bastien, 2021/09/29
- Re: [PATCH] Fix some typos, Marco Wahl, 2021/09/23