emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]


From: Timothy
Subject: Re: [PATCH]
Date: Mon, 27 Sep 2021 18:35:12 +0800
User-agent: mu4e 1.6.5; emacs 28.0.50

Hi  Bastien,

Thanks for taking a look at my patch.

Bastien <bzg@gnu.org> writes:

> On a first look, it seems a bit hackish, but this is probably useful.

Taking a look at the commit, I can see how it doesn’t look particularly tidy. I
think this is more a function of the way that function is structured than my
change though. As such, I’ve had a second look at the code, and given how large
that function is, split off the width calculation into a new function, where
I’ve re-implemented the logic in (IMO) a cleaner way.

So now, in the original function there’s just
┌────
│ (let ((width (org-display-inline-image--width link))
└────

See the attached patch for the new function `org-display-inline-image--width' 
(to
be applied on top of my previous patch). Oh, and I’ve also added support for
`:width 70%'.

All the best,
Timothy

Attachment: 0003-org-Support-displaying-X-width-images.patch
Description: Text Data

Attachment: 0002-org-Refactor-width-in-org-display-inline-images.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]