emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ox.el: add smart quotes for Greek


From: Max Nikulin
Subject: Re: [PATCH] ox.el: add smart quotes for Greek
Date: Thu, 23 Sep 2021 00:19:30 +0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

I believe, the patch is an improvement. It would be nice to have a comment clarifying the choice of secondary opening quote mark, but it is not required. It seems there is no recommendations or established practice for documenting of such decisions. I have not tested the patch though.

-`org-export-smart-quotes-alist' and `org-export-dictionary'.
+`org-export-smart-quotes-' and `org-export-dictionary'.

It it intentional change? I have not found other variables having the same prefix.

On 22/09/2021 03:20, Juan Manuel Macías wrote:
[...]
Possible options:
- Add the note directly to the .el file. I am afraid, as inline
   comment it could be considered too long.
- To a file in the "doc" directory dedicated to such decisions (there
   is no such file yet however) with a reference from the .el file.
- Commit message. It is acceptable but not apparent for a person who
   reads the code that git log may provide detailed explanation of
particular choice.
...
Haralambous is a great TeX guru, and a great scholar and theorist of
Greek typography, but... I would say that in this case his mind is more
focused on a historical tradition probably abandoned before the digital
age.

That character could get better support in future. I know, such chance is almost improbable, but imagine, a person familiar with the paper of Haralambous would consider change of the quote mark in question believing that Org developers were not aware of the "right" symbol. A comment in the source code may provide a hint that the choice was conscious.

I forgot to mention it in my message from 2020-08-15 that I did not find the U+201F character in TeX pre-unicode LG* encodings for Greek.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]