[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bug#47885: [PATCH] org-table-import: Make it more smarter for intera
From: |
Utkarsh Singh |
Subject: |
Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use |
Date: |
Tue, 01 Jun 2021 23:16:33 +0530 |
Hi Maxim,
First of all I would like to thank you for testing out patches and
taking time to write a detailed report about it.
On 2021-06-01, 23:23 +0700, Maxim Nikulin <manikulin@gmail.com> wrote:
> On 17/05/2021 12:29, Bastien wrote:
>> Utkarsh Singh <utkarsh190601@gmail.com> writes:
>>> For now can you review the patches I proposed earlier in this
>>> thread?
>>
>> Not until both you and Maxim are confident this is useful, complete
>> and predictable.
>
> I have too many points to object to consider my opinion as objective.
>
> Org 9.4.5+patches M-x org-table-import
>
> | 1,Word,66.3e-35 | | | |
> | 2,Unquoted | cell,2.7 | | |
> | 3,"Quoted | cell",3.14 | | |
> | 4,"Cell | ""with | quotes""",2021-06-01 | |
> | 5,"Next | cell | is | empty","" |
> | 6,"Cell | with | new | |
> | Line",6.28 | | | |
>
> So my personal conclusion is that CSV file is imported incorrectly in
> both cases: with guessed separator and with explicitly requested through
> prefix argument. Completion works a bit worse too.
Currently `org-table-guess-separator' returns "," (COMMA as string) and
`org-table-covert-region' uses '(4) to represent COMMA as separator
which is the main cause of breakdown in importing.
To make importing work well we have to:
+ Guess right separator (`org-table-guess-separator')
+ Parse CSV with this separator (`org-table-covert-region')
As far as I can tell "guessing part" works well and now we just have to
make parser work well with new separators.
--
Utkarsh Singh
http://utkarshsingh.xyz
- Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use, Maxim Nikulin, 2021/06/01
- Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use,
Utkarsh Singh <=
- Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use, Maxim Nikulin, 2021/06/02
- Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use, Utkarsh Singh, 2021/06/02
- Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use, Maxim Nikulin, 2021/06/02
- Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use, Utkarsh Singh, 2021/06/04
- Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use, Maxim Nikulin, 2021/06/05
- Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use, Utkarsh Singh, 2021/06/05
- Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use, Maxim Nikulin, 2021/06/09