emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch] tests for org-remove-invisible


From: Nicolas Goaziou
Subject: Re: [Patch] tests for org-remove-invisible
Date: Thu, 20 May 2021 20:06:00 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Hello,

Maxim Nikulin <manikulin@gmail.com> writes:

> The main patch that fixes org-remove-invisible to improve list sorting is 
> landed.
>
> Let me remind that there were patches that added more test cases:
> https://orgmode.org/list/s5p88r$go9$1@ciao.gmane.io
> Is there any interest in them?
>
> In the following subthread Nicolas mentioned that some of them could fail
> https://orgmode.org/list/87r1j6b6ku.fsf@nicolasgoaziou.fr
> I do not see any reason for failure. I just have tried C.UTF-8, en_US.UTF-8,
> es_ES.UTF-8, and ru_RU.UTF-8 locales (interactively) and do not see any
> problem. This set of locales has 3 different collation rules,
> however I do not think it matters for tests.

[...]

>> There is redefinition of `string-collate-lessp' to run tests with "C" locale:
>> https://code.orgmode.org/bzg/org-mode/src/master/testing/lisp/test-org-list.el#L1207

I probably missed that re-definition. Feel free to disregard my comment.

Regards,
-- 
Nicolas Goaziou



reply via email to

[Prev in Thread] Current Thread [Next in Thread]