[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] org-agenda.el: Fix clocking issues regex
|
From: |
Bastien |
|
Subject: |
Re: [PATCH] org-agenda.el: Fix clocking issues regex |
|
Date: |
Sat, 15 May 2021 16:19:56 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hi Tim,
Tim Frana <tfr@mailbox.org> writes:
> The method org-agenda-show-clocking-issues has a faulty regex, which
> leads to false-positive
> clocking issues: " Clocked: +(-\\|\\([0-9]+:[0-9]+\\))"
>
> There is no outer group to limit the OR-expression \\|, so the right
> half will match timestamps with
> a closing parenthesis without any "Clocked" in front of it.
>
> I added a non-capturing group in the attached patch: " Clocked:
> +(\\(?:-\\|\\([0-9]+:[0-9]+\\)\\))".
Applied, thanks a lot for the careful analysis and the patch with the
proper commit message.
Best,
--
Bastien