emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#47088: org-w3m: handle w3m-image link information


From: Boruch Baum
Subject: bug#47088: org-w3m: handle w3m-image link information
Date: Thu, 6 May 2021 18:05:15 -0400
User-agent: NeoMutt/20180716

On 2021-05-05 10:16, Bastien wrote:
> Thanks, it looks good.
>
> Can you try updating the patch against Org's upstream repository at
> https://code.orgmode.org/bzg/org-mode/?
>
> Note that the file is lisp/ol-w3m.el there.

1] Attached.

2] Here's a commit message in the Changelog style:

   2021-05-06  Boruch Baum  <boruch_baum@gmx.com>

        * ol-w3m.el (org-w3m-copy-for-org-mode)
        (org-w3m-get-next-link-start, org-w3m-get-prev-link-start):
        Account for w3m-img links.
        (org-w3m-get-anchor-start, org-w3m-get-prev-link-start)
        (org-w3m-no-prev-link-p): Unused function notes.
        (org-w3m-get-image-end): New function, for w3m-img links.

3] As mentioned in the patch, and in the commit message, there seem to
   be several functioned unused in the code base that could be
   candidates for removal...

        org-w3m-get-anchor-start
        org-w3m-no-prev-link-p
        org-w3m-get-prev-link-start

4] Additionally, in performing the merge I came across function
   org-string-nw-p, which seems to be an unnecessary duplicate of the
   emacs core function string-blank-p. It may be that historically you
   once needed your own home-made functions/macros, but now that emacs
   core has them, you may want to consider a refactor.

--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0

Attachment: ol-w3m.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]