[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] LaTeX export: arbitrary float environments
From: |
Timothy |
Subject: |
Re: [PATCH] LaTeX export: arbitrary float environments |
Date: |
Sat, 01 May 2021 19:08:07 +0800 |
User-agent: |
mu4e 1.4.15; emacs 28.0.50 |
Hi Thomas,
On the surface, this looks reasonable to me :)
Just commenting on some technicalities with the patch itself:
- In ORG-NEWS it would be good to wrap the content over multiple lines
instead of having a single 270 char line :)
- You seem to have an anomalous change to the ob-python :return entry
- I don't think your patch subject follows the convention for Org, it
should be:
"main file/feature: overall change summary"
so, something like
"ox-latex: allow for arbitrary float environments"
rather than
"LaTeX export: arbitrary float environments"
Thanks for the patch :)
Timothy
- Re: [PATCH] LaTeX export: arbitrary float environments,
Timothy <=