[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bug fix attached: org-babel sql postgres, fix hardcode
From: |
Kyle Meyer |
Subject: |
Re: Bug fix attached: org-babel sql postgres, fix hardcode |
Date: |
Wed, 03 Feb 2021 23:19:14 -0500 |
Thanks for the patch, and others for the review/feedback.
Alan Light writes:
> Subject: [PATCH 2/2] ob-sql.el: ob-sql.el (org-babel-execute:sql): Use
> `sql-postgres-program' as postgresql executable (instead of psql) when
> defined
>
> * ob-sql.el (org-babel-execute:sql): Use `sql-postgres-program' as
> postgresql executable (instead of psql) when defined. psql will be the
> default
I've squash this patch, which as Tom notes is a fixup on top of the
initial one, into the first. I've also tweaked the commit message a
bit, including adding TINYCHANGE.
https://orgmode.org/worg/org-contribute.html#commit-messages
> ---
> lisp/org/ob-sql.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/org/ob-sql.el b/lisp/org/ob-sql.el
> index 8eca769d02..f46c6c1c6a 100644
> --- a/lisp/org/ob-sql.el
> +++ b/lisp/org/ob-sql.el
> @@ -242,7 +242,7 @@ footer=off -F \"\t\" %s -f %s -o %s %s"
> (if dbpassword
> (format "PGPASSWORD=%s " dbpassword)
> "")
> - (or sql-postgres-program "psql")
> + (or sql-postgres-program "psql") ;; default
> is psql
As Tom noted, the use of sql-postgres-program here leads to a
byte-compiler warning. It probably makes sense to just require sql.el
in the file, but for now I've guarded this with a bound-and-true-p.
Pushed (862048d4c). Thanks again.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: Bug fix attached: org-babel sql postgres, fix hardcode,
Kyle Meyer <=