emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ob-java, a proposal on import improvement


From: ian martins
Subject: Re: [PATCH] ob-java, a proposal on import improvement
Date: Sat, 9 Jan 2021 10:51:07 -0500

On Fri, Jan 8, 2021 at 11:28 AM John Herrlin <jherrlin@gmail.com> wrote:

> I would like to combine imports from header-args with imports from a
> source block.
> ...
> I didnt get the to work so I made a patch.

John, Sorry that wasn't working. Thanks for investigating and
submitting a fix.  I think the problem was that I was missing static
imports, which you fixed in the first chunk of your patch. I don't
think the rest of the change is necessary. Could you revert the other
chunks and re-test?

This works for me using master, and your patch produces nearly the
same code (only import order differs):

    #+begin_src java :results output :imports java.util.HashMap
      import java.util.Map;

      Map<String, Integer> hash = new HashMap<>();
      hash.put("one", 1);
      hash.put("two", 2);
      System.out.println(hash);
    #+end_src



reply via email to

[Prev in Thread] Current Thread [Next in Thread]