[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bug: Babel+R handles spaces wrongly in tables [9.3.6 (release_9.3.6
From: |
Jeremie Juste |
Subject: |
Re: Bug: Babel+R handles spaces wrongly in tables [9.3.6 (release_9.3.6 @ /home/cassou/.emacs.d/lib/org/lisp/)] |
Date: |
Sat, 19 Dec 2020 14:45:46 +0100 |
Hello,
Apologies for the late reply and thanks for pointing out this bug.
|| On Sunday, 6 Sep 2020 at 13:32, Damien Cassou wrote:
#+name: table
| | 2014 |
|-----+------|
| A C | 1 |
| C | 2 |
#+name: linechart
#+begin_src R :results value :var accounts="" :exports none
length(accounts)
#+end_src
#+call: linechart(accounts=table[,0])
#+RESULTS:
: 3
Currently there are no support for vectors. So it is either a
data.frame or an object of length 1.
|| On Sun, 06 Sep 2020 18:23:19 Berry, Charles" wrote
> Actually the length should be 1, i.e. a data.frame with a single column of
> two elements.
Indeed with the current handling the length should be 1 but it is
not. Even with the previous case solved, it might still be an
unexpected behavior for a typical R user who would expect a vector. Do you
think it is reasonable?
The following patch will at least harmonize the results towards the
data.frame.
diff --git a/lisp/ob-R.el b/lisp/ob-R.el
index 420b8ccbc..81693d157 100644
--- a/lisp/ob-R.el
+++ b/lisp/ob-R.el
@@ -236,11 +236,11 @@ This function is called by `org-babel-execute-src-block'."
(defun org-babel-R-assign-elisp (name value colnames-p rownames-p)
"Construct R code assigning the elisp VALUE to a variable named NAME."
(if (listp value)
- (let* ((value (if (listp (car value)) value (list value)))
- (lengths (mapcar 'length (cl-remove-if-not 'sequencep value)))
+ (let* ((lengths (mapcar 'length (cl-remove-if-not 'sequencep value)))
(max (if lengths (apply 'max lengths) 0))
(min (if lengths (apply 'min lengths) 0)))
;; Ensure VALUE has an orgtbl structure (depth of at least 2).
+ (unless (listp (car value)) (setq value (list value)))
(let ((file (orgtbl-to-tsv value '(:fmt org-babel-R-quote-tsv-field)))
(header (if (or (eq (nth 1 value) 'hline) colnames-p)
"TRUE" "FALSE"))
so the following will return a data.frame
#+begin_src R :results output :var accounts=(identity '("A B" "C"))
print(accounts)
#+end_src
#+RESULTS:
: V1 V2
: 1 A B C
I will add support for selection of 1 single column as a
vector soon.
Best regards,
Jeremie
PS: I am a newbie maintainer so feel free to comment if there you find
room for improvements ;-)
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: Bug: Babel+R handles spaces wrongly in tables [9.3.6 (release_9.3.6 @ /home/cassou/.emacs.d/lib/org/lisp/)],
Jeremie Juste <=