[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] babel latex headers and image generation commands
From: |
Bastien |
Subject: |
Re: [PATCH] babel latex headers and image generation commands |
Date: |
Sat, 24 Oct 2020 14:30:36 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hi Matt,
sorry for the delayed answer.
Matt Huszagh <huszaghmatt@gmail.com> writes:
> Bastien <bzg@gnu.org> writes:
>
>> Prefer
>>
>> * lisp/ob-latex.el (org-babel-latex-preamble): New option for LaTeX
>> preamble customization.
>>
>> "New option" is quite standard, an "option" being a customizable
>> variable. In this case, "New option" would probably be enough, given
>> the name of the option is quite self-explanatory. Also, some find it
>> pedantic, but "LaTeX" is the correct spelling in a changelog I guess.
>
> Fixed in new patch (attached).
Applied as ae35a3459, thanks!
>> The first line of the docstring should contain a sentence, so you'd
>> need to have a new paragraph after "runtime to the LaTeX preamble."
>
> Also fixed. Making the first line a full sentence means that some lines
> are a little longer than 80 characters. Is this acceptable?
>
>> What for users who don't have inkscape?
>
> This is just a default, but I could use a dvisvgm command as the default
> instead? Either way, converting a PDF to SVG will require an executable
> outside Emacs, but I guess dvisvgm is more likely to be installed for
> people using a texlive installation. My personal preference for inkscape
> is because it should handle all PDF inputs, whereas there are some cases
> where dvisvgm may fail (see
> https://github.com/mgieseki/dvisvgm/issues/139) due to changes in
> ghostscript. Still, dvisvgm generally does a very good job with PDF
> inputs. Let me know your thoughts, I'd be happy to set the default to a
> dvisvgm command instead.
Let's see what people think when they try it after 9.5.
Can you provide a patch against etc/ORG-NEWS announce this?
Thanks,
--
Bastien
- Re: [PATCH] babel latex headers and image generation commands,
Bastien <=