[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Revert "Fix encrypt/decrypt in presence of arbitrary drawers"
From: |
Nicolas Goaziou |
Subject: |
Re: Revert "Fix encrypt/decrypt in presence of arbitrary drawers" |
Date: |
Sun, 13 Sep 2020 21:25:27 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hello,
Bastien <bzg@gnu.org> writes:
> I pushed a fix in master (755367f36) that should prevent the problem
> you are pointing too while fixing the problem the OP reported.
I think this is still sub-optimal.
`org-logbook-drawer-re' doesn't mean much, because it hard-codes
"LOGBOOK" whereas `org-log-into-drawer' could have an entire different
value, including nil. As long as users can add log notes elsewhere than
into "LOGBOOK" drawer, the check you implemented will not work reliably.
I think encrypted entries should be considered as read-only. You should
not be able to reschedule them, or add a note, as long as
`org-at-encrypted-entry-p' is non-nil. I don't think you can handle the
initial problem otherwise.
Regards,
--
Nicolas Goaziou