Re: [PATCH] org-element: Hide parsers boilerplate into plist-creating macros

[Nicolas Goaziou]

Hello,

Bastien <bzg@gnu.org> writes:

> akater <nuclearspace@gmail.com> writes:
>
>> We replace some repetetive code with macro calls org-prog-plist and
>> org-let*-prog-plist.
>
> IIUC this is a refactoring, it does not add or remove functionalities?
>
> I'll let Nicolas decide on this, of course.

FWIW, I'm not convinced there's a significant advantage in doing this
refactoring. Arguably, the code is not more readable. It will not make
it faster either.

There is room for refactoring in Org (for the record, org-agenda.el has
not switched to lexical binding yet), but I don't think org-element.el
has bitrotten so much that it deserves some.

Regards,
-- 
Nicolas Goaziou