emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use completing-read-multiple for org-set-tags-command


From: Clemens
Subject: Re: [PATCH] Use completing-read-multiple for org-set-tags-command
Date: Mon, 20 Jul 2020 08:03:04 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

> Note, though, that org-set-tags-command already supports completing
> multiple tags through org-tags-completion-function, which it passes as
> the COLLECTION argument to completing-read.  In order to see that in
> action, you may need to tell the completion library you use to fall back
> to the built-in completing-read.  As an example, I use Helm and have
> this in my configuration:
>
>      (add-to-list 'helm-completing-read-handlers-alist
>                   '(org-set-tags-command))
>

I looked and helm-org does include a similar adjustment to make it work
correctly:


https://github.com/emacs-helm/helm-org/blob/b7a18dfc17e8b933956d61d68c435eee03a96c24/helm-org.el#L490-L523

My patch aims to get you completion with the default completion and also
for any framework that complies to it out of the box. Without my patch
(and without helm-org) you don't get completion after the first tag I think.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]