emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] When inserting entry template, don't include last newline in


From: Kyle Meyer
Subject: Re: [patch] When inserting entry template, don't include last newline in narrowed zone
Date: Sun, 28 Jun 2020 12:28:14 -0400

E.L.K. writes:

> Hello.
>
> Org 9.3.6: when inserting the entry by capture mechanics, it narrows buffer
> in a way that cursor can be moved to the last line, which is the beginning
> of next (non-capture template) line in the original unnarowed buffer.
>
> So this allows to: start capture, move point to the very last char of the
> narrowed buffer, insert something. If this line in unnarowed buffer was
> start of heading, it breaks structure of document.
>
> This is patch in attempt to fix it. I followed same approach as in
> org-capture-place-item function.

Thanks.  AFAICT this issue, along with the hidden SCHEDULE line you
mention in the next commit, is resolved on the master branch (what will
be v9.4).  The last commit in this area is 6882478ca (capture: Fix
org-capture-place-entry narrow bounds, 2020-05-29).

> Common subdirectories: org-9.3.6/etc and /home/elk/.emacs.d/elpa/org-9.3.6/etc
> diff -U5 org-9.3.6/org-capture.el 
> /home/elk/.emacs.d/elpa/org-9.3.6/org-capture.el
> --- org-9.3.6/org-capture.el  2020-06-15 19:04:19.061012833 +0300
> +++ /home/elk/.emacs.d/elpa/org-9.3.6/org-capture.el  2020-06-28 
> 13:08:04.446045559 +0300

For future reference: This doesn't quite match this project's
conventions for patch submissions.  More information is here:
<https://orgmode.org/worg/org-contribute.html>.

Thanks again.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]